Skip to content

fix: address zizmor security findings#55

Open
Daniel-Aaron-Bloom wants to merge 1 commit into
wormhole-foundation:mainfrom
Daniel-Aaron-Bloom:fix/zizmor-findings
Open

fix: address zizmor security findings#55
Daniel-Aaron-Bloom wants to merge 1 commit into
wormhole-foundation:mainfrom
Daniel-Aaron-Bloom:fix/zizmor-findings

Conversation

@Daniel-Aaron-Bloom

Copy link
Copy Markdown

Summary

This PR addresses zizmor security findings in the GitHub Actions workflow and Dependabot configuration.

Findings fixed

  • dependabot-cooldown (.github/dependabot.yml): Added cooldown: default-days: 7 to the npm ecosystem entry to prevent excessive update churn.
  • unpinned-uses (.github/workflows/sdk-type-check.yml): Pinned wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml to full commit SHA 3d6ccc988ec1949b31751a30845151b979987246 # main.
  • secrets-inherit (.github/workflows/sdk-type-check.yml): Removed secrets: inherit — the called reusable workflow does not declare named secret inputs and does not need access to all parent secrets.

Test plan

  • Verify zizmor CI passes on this PR with no remaining findings

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
typecheck-latest:
uses: wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml@main
secrets: inherit No newline at end of file
uses: wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml@3d6ccc988ec1949b31751a30845151b979987246 # main No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment feels a little misleading as it won't be the tip of main going forwards, but no biggie

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have any tag, so this felt like the least misleading way of giving some info of where we got the commit hash from (i.e. not a tag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants